-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📦 Use nodeenv
when Node.js can't be found by Python package
#1487
Conversation
|
@rowanc1 I've added an |
Can you rebase this on the docs PR that just got merged. My understanding is that this will simplify the pip install instructions? |
85b5ea0
to
1eaeebe
Compare
I have lifted the custom build hook into https://github.com/jupyter-book/hatch-deps-selector/, which means that others can also use it. Simply put, this plugin makes it possible for us to add additional predefined dependencies to our package metadata at build-time by setting an environment variable. We will update our conda-forge deployment to reflect this. |
This PR now should hold until conda-forge/staged-recipes#27417 is merged, so that we can immediately update our feedstock recipe. |
@rowanc1 conda-forge now ships the new package required to make this work :) |
0e3b176
to
283bc76
Compare
Adding a pre-built wheel to test on Windows... |
@rowanc1 this has been tested on Windows and Linux, and works as expected. We can review during today's meeting if helpful. |
nodeenv
when Node.js can't be found by Python packagenodeenv
when Node.js can't be found by Python package
Fixes #1443 by using
nodeenv
to provision a Node.js environment for installs of our Python package.Here's an example running in Podman (the final crash appears container related)
https://github.com/user-attachments/assets/9ca90520-f1fa-4d37-a6da-a64edc5f0a83